fix EAS_SetSoundLibrary and EAS_LoadDLSCollection #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling EAS_SetSoundLibrary() with a stream handle opened with EAS_OpenMIDIStream(), the caller gets a SIGSEGV. Same for EAS_LoadDLSCollection.
rsp4jack
approved these changes
Jan 31, 2026
pedrolcl
deleted the
fix-for-EAS_SetSoundLibrary-and-EAS_LoadDLSCollection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling EAS_SetSoundLibrary() with a stream handle opened with EAS_OpenMIDIStream(), the caller gets a SIGSEGV.
Same for EAS_LoadDLSCollection.
Description
in EAS_SetSoundLibrary and EAS_LoadDLSCollection, if pStream->pParserModule is NULL, then we assume that pStream->handle shall be a S_INTERACTIVE_MIDI *, which has an initialized pSynth member that we may pass to the functions VMSetEASLib and VMSetDLSLib.
Related Issues
Closes #8
Checklist